This repository was archived by the owner on Apr 20, 2018. It is now read-only.
Adding arraybuffer xhr responseType support#121
Open
neilcampbell wants to merge 4 commits intoReactive-Extensions:masterfrom
Open
Adding arraybuffer xhr responseType support#121neilcampbell wants to merge 4 commits intoReactive-Extensions:masterfrom
neilcampbell wants to merge 4 commits intoReactive-Extensions:masterfrom
Conversation
Author
|
Also should I be committing an updated dist and modules directory? |
tests/ajax/tests.ajax.js
Outdated
| ok(false); | ||
| }, | ||
| function (x) { | ||
| function (x) { |
Author
There was a problem hiding this comment.
No I didn't, sorry about that will get that fixed.
Contributor
|
No don't commit to module and dist. Just include src file changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ajax arraybuffer xhr responseType support.
I have also built this in a generic way, which means any valid xhr responseType (given the target browser supports it) can be used now.